Pipedrive - New Actions #17387
Pipedrive - New Actions #17387
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThis update introduces two new Pipedrive action modules: one for retrieving a lead by its ID and another for searching leads. Supporting methods are added to the Pipedrive app integration, and a new constant is defined. Additionally, version numbers are incremented across multiple action and source components, and the package version is updated. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GetLeadByIdAction
participant PipedriveApp
participant LeadsApi
User->>GetLeadByIdAction: Provide leadId
GetLeadByIdAction->>PipedriveApp: getLead(leadId)
PipedriveApp->>LeadsApi: getLead({ id: leadId })
LeadsApi-->>PipedriveApp: Lead data
PipedriveApp-->>GetLeadByIdAction: Lead data
GetLeadByIdAction-->>User: Lead data
sequenceDiagram
participant User
participant SearchLeadsAction
participant PipedriveApp
participant LeadsApi
User->>SearchLeadsAction: Provide search/filter parameters
SearchLeadsAction->>PipedriveApp: searchLeads(options)
PipedriveApp->>LeadsApi: searchLeads(options)
LeadsApi-->>PipedriveApp: List of leads
PipedriveApp-->>SearchLeadsAction: List of leads
SearchLeadsAction-->>User: List of leads
Assessment against linked issues
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/pipedrive/actions/search-leads/search-leads.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🔭 Outside diff range comments (2)
components/pipedrive/actions/add-lead/add-lead.mjs (1)
111-116: Isolate note-creation failure so the lead still succeedsIf
addNotefails, the whole action currently throws, even though the lead was created successfully. Wrapping the secondary call prevents losing the primary result:-if (this.note) { - await this.pipedrive.addNote({ - content: this.note, - lead_id: response.data?.id, - }); -} +if (this.note) { + try { + await this.pipedrive.addNote({ + content: this.note, + lead_id: response.data?.id, + }); + } catch (err) { + this.$logger.warn(`Lead created but note failed to add: ${err?.message || err}`); + } +}components/pipedrive/sources/updated-lead-instant/updated-lead-instant.mjs (1)
24-28: Incorrect helper used for lead custom fields
parseData()callsthis.pipedrive.getDealCustomFields, but this source emits Lead-update events. Mixing deal helpers with lead objects will return the wrong field schema and may break downstream workflows.- fn: this.pipedrive.getDealCustomFields, + // TODO: implement getLeadCustomFields (or equivalent) in the app and use it here + fn: this.pipedrive.getLeadCustomFields,If a dedicated helper doesn’t exist yet, fall back to
this.pipedrive.getLeadand extractcustom_fieldsmanually.Please adjust before publishing to avoid mismatched payloads.
🧹 Nitpick comments (5)
components/pipedrive/package.json (1)
3-3: 👍 Version bump looks consistent with new feature set
0.9.0aligns with the new lead-related actions introduced in this PR.
Please remember to update any CHANGELOG / release notes so downstream users understand the new capability.components/pipedrive/actions/remove-duplicate-notes/remove-duplicate-notes.mjs (1)
68-72: Avoid mutating the originalnotesarray during sort
Array.prototype.sortoperates in-place, so callers that rely on the original ordering will observe side-effects. Consider cloning first:-const sortedNotes = notes.sort((a, b) => { +const sortedNotes = [...notes].sort((a, b) => {components/pipedrive/actions/get-person-details/get-person-details.mjs (1)
29-31: Preserve original error object for easier debugging
catch ({ error })silently drops stack traces when the thrown value isn’t an object with anerrorfield. Safer pattern:-} catch ({ error }) { - throw new ConfigurationError(error); +} catch (err) { + throw new ConfigurationError(err?.message || err); }components/pipedrive/actions/search-notes/search-notes.mjs (1)
136-172: Move content search server-side to avoid O(N) post-filtering
searchTermis applied after the full result set is retrieved, which can pull thousands of notes into memory and burn API quota unnecessarily.
Pipedrive’s API supports searching by term (termquery param on/notes/search) so you can delegate filtering to the backend and request far fewer pages.- let notes = await this.pipedriveApp.getPaginatedResources({ - fn: this.pipedriveApp.getNotes, - params: { + let notes = await this.pipedriveApp.getPaginatedResources({ + fn: this.pipedriveApp.getNotes, + params: { + term: this.searchTerm || undefined, user_id: this.userId, @@ - if (this.searchTerm) { - notes = notes.filter((note) => - note.content?.toLowerCase().includes(this.searchTerm.toLowerCase())); - } + /* post-filter no longer needed */Result: less data over the wire, smaller memory footprint, and faster execution.
components/pipedrive/common/constants.mjs (1)
38-42: Minor consistency nits for the newLEAD_FIELD_OPTIONS
- Consider alphabetising the values (
"custom_fields", "notes", "title") to match the style ofFIELD_OPTIONS.- Keep the exported keys in sorted order to aid quick scans (
DEFAULT_PAGE_LIMIT, FIELD, LEAD_FIELD_OPTIONS, ...).Purely stylistic—no functional impact.
Also applies to: 51-51
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (22)
components/pipedrive/actions/add-activity/add-activity.mjs(1 hunks)components/pipedrive/actions/add-deal/add-deal.mjs(1 hunks)components/pipedrive/actions/add-lead/add-lead.mjs(1 hunks)components/pipedrive/actions/add-note/add-note.mjs(1 hunks)components/pipedrive/actions/add-organization/add-organization.mjs(1 hunks)components/pipedrive/actions/add-person/add-person.mjs(1 hunks)components/pipedrive/actions/get-lead-by-id/get-lead-by-id.mjs(1 hunks)components/pipedrive/actions/get-person-details/get-person-details.mjs(1 hunks)components/pipedrive/actions/remove-duplicate-notes/remove-duplicate-notes.mjs(1 hunks)components/pipedrive/actions/search-leads/search-leads.mjs(1 hunks)components/pipedrive/actions/search-notes/search-notes.mjs(1 hunks)components/pipedrive/actions/search-persons/search-persons.mjs(1 hunks)components/pipedrive/actions/update-deal/update-deal.mjs(1 hunks)components/pipedrive/actions/update-person/update-person.mjs(1 hunks)components/pipedrive/common/constants.mjs(1 hunks)components/pipedrive/package.json(1 hunks)components/pipedrive/pipedrive.app.mjs(1 hunks)components/pipedrive/sources/new-deal-instant/new-deal-instant.mjs(1 hunks)components/pipedrive/sources/new-person-instant/new-person-instant.mjs(1 hunks)components/pipedrive/sources/updated-deal-instant/updated-deal-instant.mjs(1 hunks)components/pipedrive/sources/updated-lead-instant/updated-lead-instant.mjs(1 hunks)components/pipedrive/sources/updated-person-instant/updated-person-instant.mjs(1 hunks)
🧰 Additional context used
🧠 Learnings (20)
components/pipedrive/actions/add-organization/add-organization.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/pipedrive/package.json (2)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
Learnt from: js07
PR: PipedreamHQ/pipedream#17375
File: components/zerobounce/actions/get-validation-results-file/get-validation-results-file.mjs:23-27
Timestamp: 2025-07-01T17:07:48.143Z
Learning: "dir" props in Pipedream components are hidden in the component form and not user-facing, so they don't require labels or descriptions for user clarity.
components/pipedrive/actions/remove-duplicate-notes/remove-duplicate-notes.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/pipedrive/actions/update-deal/update-deal.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/pipedrive/sources/new-person-instant/new-person-instant.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/pipedrive/actions/add-person/add-person.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/pipedrive/actions/add-deal/add-deal.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/pipedrive/actions/search-persons/search-persons.mjs (2)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
components/pipedrive/actions/get-person-details/get-person-details.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/pipedrive/actions/update-person/update-person.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/pipedrive/actions/add-activity/add-activity.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/pipedrive/sources/updated-lead-instant/updated-lead-instant.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/pipedrive/sources/new-deal-instant/new-deal-instant.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/pipedrive/sources/updated-person-instant/updated-person-instant.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/pipedrive/actions/add-lead/add-lead.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/pipedrive/pipedrive.app.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: The Salesloft API list endpoints (listPeople, listCadences, listUsers, listAccounts) return arrays directly in the response body, not wrapped in a metadata object with a nested data property. The _makeRequest method correctly returns response.data which contains the arrays that can be mapped over directly in propDefinitions.
components/pipedrive/sources/updated-deal-instant/updated-deal-instant.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/pipedrive/actions/get-lead-by-id/get-lead-by-id.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/pipedrive/actions/add-note/add-note.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/pipedrive/actions/search-leads/search-leads.mjs (2)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (21)
components/pipedrive/actions/update-deal/update-deal.mjs (1)
8-8: LGTM - Version increment as part of coordinated update.The version bump from "0.1.14" to "0.1.15" is appropriate and aligns with the coordinated update across multiple Pipedrive components to support the new lead functionality.
components/pipedrive/sources/new-deal-instant/new-deal-instant.mjs (1)
9-9: LGTM - Version increment as part of coordinated update.The version bump from "0.0.8" to "0.0.9" is appropriate and consistent with the overall Pipedrive integration update.
components/pipedrive/pipedrive.app.mjs (2)
452-457: LGTM - Well-structured getLead method.The
getLeadmethod follows the established pattern in the codebase, using the default API version and properly structuring the request with the lead ID parameter.
458-461: LGTM - Well-structured searchLeads method.The
searchLeadsmethod follows the established pattern and appropriately uses API version "v2" for search functionality, with proper default parameter handling.components/pipedrive/actions/add-organization/add-organization.mjs (1)
8-8: LGTM - Version increment as part of coordinated update.The version bump from "0.1.12" to "0.1.13" is appropriate and consistent with the coordinated update across Pipedrive action components.
components/pipedrive/actions/add-activity/add-activity.mjs (1)
10-10: LGTM - Version increment as part of coordinated update.The version bump from "0.1.12" to "0.1.13" is appropriate and aligns with the coordinated update across multiple Pipedrive action components.
components/pipedrive/actions/remove-duplicate-notes/remove-duplicate-notes.mjs (1)
8-8: No functional change – version bump onlyNothing else to flag on the metadata update.
components/pipedrive/actions/get-person-details/get-person-details.mjs (1)
8-8: Metadata looks goodVersion bump is fine.
components/pipedrive/actions/add-lead/add-lead.mjs (1)
9-9: Version bump acknowledgedNo issues with the metadata.
components/pipedrive/actions/search-persons/search-persons.mjs (2)
10-10: LGTM on version updateMetadata only, nothing further here.
64-65: Double-checkfieldsserialization
parseObject(this.fields)may return the same array, but the API expects a comma-separated string. Confirm thatparseObjectconverts arrays to the expected"field1,field2"format; otherwise, serialize explicitly:-fields: parseObject(this.fields), +fields: Array.isArray(this.fields) ? this.fields.join(",") : this.fields,components/pipedrive/sources/new-person-instant/new-person-instant.mjs (1)
9-9: Version bump acknowledged – looks goodThe minor version increment is consistent with the other components in this PR. No further action required.
components/pipedrive/actions/add-person/add-person.mjs (1)
9-9: Version bump acknowledged – looks goodVersion update aligns with the coordinated release across the Pipedrive integration. No issues found.
components/pipedrive/actions/add-deal/add-deal.mjs (1)
8-8: Version bump acknowledged – looks goodChange is isolated to the version field; implementation remains intact.
components/pipedrive/actions/update-person/update-person.mjs (1)
9-9: Version bump acknowledged – looks goodPatch-level version increment is appropriate; no functional impact observed.
components/pipedrive/actions/add-note/add-note.mjs (1)
8-8: Version bump acknowledged – looks goodConsistent with other action updates; nothing else changed.
components/pipedrive/sources/updated-deal-instant/updated-deal-instant.mjs (1)
10-10: Version bump looks goodNo functional changes introduced—only the patch-level version increment to
0.1.2, which keeps the component in sync with the coordinated release across the integration. 👍components/pipedrive/sources/updated-person-instant/updated-person-instant.mjs (1)
10-10: Patch version bump acknowledgedThe increase to
0.1.2keeps the component aligned with the wider release. No further concerns.components/pipedrive/actions/get-lead-by-id/get-lead-by-id.mjs (1)
1-25: LGTM! Well-structured action component.The implementation follows Pipedream conventions correctly:
- Proper import and component structure
- Clear prop definition with appropriate propDefinition reference
- Clean run method that calls the app method, exports summary, and returns data
- Good documentation link and descriptive summary message
components/pipedrive/actions/search-leads/search-leads.mjs (2)
54-67: LGTM! Well-implemented search functionality.The run method correctly:
- Calls the app's searchLeads method with proper parameter mapping
- Handles the response data structure with appropriate destructuring
- Implements proper pluralization logic in the summary
- Returns the items array as expected
28-28:LEAD_FIELD_OPTIONSverifiedThe constant is declared and exported in
components/pipedrive/common/constants.mjs. No further action required.
Resolves #17359
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Chores